Add more tests to TestMatchers#3362
Merged
gotjosh merged 1 commit intoprometheus:mainfrom May 16, 2023
Merged
Conversation
Signed-off-by: George Robinson <george.robinson@grafana.com>
grobinson-grafana
force-pushed
the
grobinson/add-more-tests-matchers
branch
from
6a6b790 to
daabfe7
Compare
gotjosh
approved these changes
May 16, 2023
Member
gotjosh
left a comment
gotjosh
left a comment
There was a problem hiding this comment.
LGTM
Thanks for your contribution!
gotjosh
pushed a commit
that referenced
this pull request
Aug 7, 2023
Signed-off-by: George Robinson <george.robinson@grafana.com>
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
Signed-off-by: George Robinson <george.robinson@grafana.com>
qinxx108
pushed a commit
to amazon-contributing/alertmanager
that referenced
this pull request
Mar 28, 2024
Signed-off-by: George Robinson <george.robinson@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #3353, I'd like confidence in the current test suite to catch any regressions from introducing a new parser.
This adds two cases where we expect to parsing to fail.