Skip to content

Log a warning when repeat_interval is less than group_interval#3389

Merged
gotjosh merged 2 commits intoprometheus:mainfrom
grobinson-grafana:grobinson/3370
Jun 8, 2023
Merged

Log a warning when repeat_interval is less than group_interval#3389
gotjosh merged 2 commits intoprometheus:mainfrom
grobinson-grafana:grobinson/3370

Conversation

@grobinson-grafana
Copy link
Collaborator

@grobinson-grafana grobinson-grafana commented Jun 8, 2023

This commit updates Alertmanager to log a warning when repeat_interval is less than group_interval for an individual route.

When repeat_interval is less than group_interval, the earliest a notification can be sent again is the next time the aggregation group is flushed, and this happens at each group_interval.

Fixes #3370

This commit updates Alertmanager to log a warning when
repeat_interval is less than group_interval for an individual route.

When repeat_interval is less than group_interval, the earliest
a notification can be sent again is the next time the aggregation
group is flushed, and this happens at each group_interval.

Signed-off-by: George Robinson <george.robinson@grafana.com>
@grobinson-grafana
Copy link
Collaborator Author

You can find more information about this in a blog post I wrote called Group wait, Group interval and Repeat interval.

Copy link
Member

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: George Robinson <george.robinson@grafana.com>
@gotjosh gotjosh enabled auto-merge (squash) June 8, 2023 20:55
@gotjosh gotjosh merged commit 229ecb7 into prometheus:main Jun 8, 2023
gotjosh added a commit that referenced this pull request Aug 7, 2023
* Log a warning when repeat_interval is less than group_interval

This commit updates Alertmanager to log a warning when
repeat_interval is less than group_interval for an individual route.

When repeat_interval is less than group_interval, the earliest
a notification can be sent again is the next time the aggregation
group is flushed, and this happens at each group_interval.

Signed-off-by: George Robinson <george.robinson@grafana.com>
---------

Signed-off-by: George Robinson <george.robinson@grafana.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
radek-ryckowski pushed a commit to goldmansachs/alertmanager that referenced this pull request Nov 6, 2023
…theus#3389)

* Log a warning when repeat_interval is less than group_interval

This commit updates Alertmanager to log a warning when
repeat_interval is less than group_interval for an individual route.

When repeat_interval is less than group_interval, the earliest
a notification can be sent again is the next time the aggregation
group is flushed, and this happens at each group_interval.

Signed-off-by: George Robinson <george.robinson@grafana.com>
---------

Signed-off-by: George Robinson <george.robinson@grafana.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
qinxx108 pushed a commit to amazon-contributing/alertmanager that referenced this pull request Mar 28, 2024
…theus#3389)

* Log a warning when repeat_interval is less than group_interval

This commit updates Alertmanager to log a warning when
repeat_interval is less than group_interval for an individual route.

When repeat_interval is less than group_interval, the earliest
a notification can be sent again is the next time the aggregation
group is flushed, and this happens at each group_interval.

Signed-off-by: George Robinson <george.robinson@grafana.com>
---------

Signed-off-by: George Robinson <george.robinson@grafana.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
@grobinson-grafana grobinson-grafana deleted the grobinson/3370 branch April 16, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

repeat_interval doesn't work if less than group_interval

2 participants