Skip to content

Update email.html to use "https://schema.org" instead of "http://schema.org"#3420

Merged
gotjosh merged 1 commit intoprometheus:mainfrom
alvinlin123:patch-1
Aug 3, 2023
Merged

Update email.html to use "https://schema.org" instead of "http://schema.org"#3420
gotjosh merged 1 commit intoprometheus:mainfrom
alvinlin123:patch-1

Conversation

@alvinlin123
Copy link
Contributor

@alvinlin123 alvinlin123 commented Jul 7, 2023

According to schema.org's faq both https and http are fine, but https is preferred going forward: https://schema.org/docs/faq.html#19

Why am I making this change? To make some security code scanner happy :)

…ema.org"

According to schema.org's faq both https and http are fine, but https is preferred going forward: https://schema.org/docs/faq.html#19

Why am I making this change? To make some security code scanner happy :) 

Signed-off-by: Alvin Lin <alvinlin123@gmail.com>
@alvinlin123 alvinlin123 changed the title Update email.html to use "https://schema.org" instead of "https://sch… Update email.html to use "https://schema.org" instead of "https://schema.org" Jul 7, 2023
@gotjosh gotjosh merged commit 7411e54 into prometheus:main Aug 3, 2023
@gotjosh
Copy link
Member

gotjosh commented Aug 3, 2023

Thank you very much for your contribution.

@alvinlin123 alvinlin123 changed the title Update email.html to use "https://schema.org" instead of "https://schema.org" Update email.html to use "https://schema.org" instead of "http://schema.org" Aug 3, 2023
simonpasquier added a commit to simonpasquier/alertmanager that referenced this pull request Aug 3, 2023
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier added a commit to simonpasquier/alertmanager that referenced this pull request Aug 4, 2023
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier added a commit to simonpasquier/alertmanager that referenced this pull request Aug 4, 2023
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
gotjosh pushed a commit that referenced this pull request Aug 4, 2023
* Add template/email.tmpl to the clean target

The change ensures that all assets can be regenerated from scratch in
the CI.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

* Update email assets after #3420

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

---------

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
gotjosh pushed a commit that referenced this pull request Aug 7, 2023
…ema.org" (#3420)

According to schema.org's faq both https and http are fine, but https is preferred going forward: https://schema.org/docs/faq.html#19

Why am I making this change? To make some security code scanner happy :)

Signed-off-by: Alvin Lin <alvinlin123@gmail.com>
gotjosh pushed a commit that referenced this pull request Aug 7, 2023
* Add template/email.tmpl to the clean target

The change ensures that all assets can be regenerated from scratch in
the CI.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

* Update email assets after #3420

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

---------

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
radek-ryckowski pushed a commit to goldmansachs/alertmanager that referenced this pull request Nov 6, 2023
…ema.org" (prometheus#3420)

According to schema.org's faq both https and http are fine, but https is preferred going forward: https://schema.org/docs/faq.html#19

Why am I making this change? To make some security code scanner happy :)

Signed-off-by: Alvin Lin <alvinlin123@gmail.com>
radek-ryckowski pushed a commit to goldmansachs/alertmanager that referenced this pull request Nov 6, 2023
* Add template/email.tmpl to the clean target

The change ensures that all assets can be regenerated from scratch in
the CI.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

* Update email assets after prometheus#3420

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

---------

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
qinxx108 pushed a commit to amazon-contributing/alertmanager that referenced this pull request Mar 28, 2024
…ema.org" (prometheus#3420)

According to schema.org's faq both https and http are fine, but https is preferred going forward: https://schema.org/docs/faq.html#19

Why am I making this change? To make some security code scanner happy :)

Signed-off-by: Alvin Lin <alvinlin123@gmail.com>
qinxx108 pushed a commit to amazon-contributing/alertmanager that referenced this pull request Mar 28, 2024
* Add template/email.tmpl to the clean target

The change ensures that all assets can be regenerated from scratch in
the CI.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

* Update email assets after prometheus#3420

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

---------

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants