Merged
Conversation
Signed-off-by: gotjosh <josue.abreu@gmail.com>
- typo in respond - add PR numbers for UTF-8 Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
grobinson-grafana
approved these changes
Feb 14, 2024
wait until `p2.Status()` returns because it blocks until we're ready - that way, we're guaranteed to know that the cluster size is 2. Signed-off-by: gotjosh <josue.abreu@gmail.com>
th0th
pushed a commit
to th0th/alertmanager
that referenced
this pull request
Mar 23, 2024
* Release: Cut 0.27.0-rc.0 Signed-off-by: gotjosh <josue.abreu@gmail.com> * small fixes - typo in respond - add PR numbers for UTF-8 Signed-off-by: gotjosh <josue.abreu@gmail.com> * more worthsmithing Signed-off-by: gotjosh <josue.abreu@gmail.com> * Fix flaky test TestClusterJoinAndReconnect/TestTLSConnection (prometheus#3722) wait until `p2.Status()` returns because it blocks until we're ready - that way, we're guaranteed to know that the cluster size is 2. Signed-off-by: gotjosh <josue.abreu@gmail.com> --------- Signed-off-by: gotjosh <josue.abreu@gmail.com> Signed-off-by: Gokhan Sari <gokhan@sari.me>
tjhop
pushed a commit
to tjhop/alertmanager
that referenced
this pull request
Nov 13, 2025
* Release: Cut 0.27.0-rc.0 Signed-off-by: gotjosh <josue.abreu@gmail.com> * small fixes - typo in respond - add PR numbers for UTF-8 Signed-off-by: gotjosh <josue.abreu@gmail.com> * more worthsmithing Signed-off-by: gotjosh <josue.abreu@gmail.com> * Fix flaky test TestClusterJoinAndReconnect/TestTLSConnection (prometheus#3722) wait until `p2.Status()` returns because it blocks until we're ready - that way, we're guaranteed to know that the cluster size is 2. Signed-off-by: gotjosh <josue.abreu@gmail.com> --------- Signed-off-by: gotjosh <josue.abreu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare for the release of 0.27