#3513: Rewrite TestTimeActiveStage tests#3795
Merged
gotjosh merged 1 commit intoprometheus:mainfrom Apr 11, 2024
Merged
Conversation
This commit rewrites the existing TestTimeActiveStage unit tests to have complete isolation between test cases. Before this change, each test case affected the state of its subsequent tests. The motivation behind this change is to make it easier to assert that alerts have been marked as muted. Signed-off-by: George Robinson <george.robinson@grafana.com>
This was referenced Apr 2, 2024
grobinson-grafana
changed the title
tjhop
pushed a commit
to tjhop/alertmanager
that referenced
this pull request
Nov 13, 2025
This commit rewrites the existing TestTimeActiveStage unit tests to have complete isolation between test cases. Before this change, each test case affected the state of its subsequent tests. The motivation behind this change is to make it easier to assert that alerts have been marked as muted. Signed-off-by: George Robinson <george.robinson@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit rewrites the existing TestTimeActiveStage unit tests to have complete isolation between test cases. Before this change, each test case affected the state of its subsequent tests.
The motivation behind this change is to make it easier to assert that alerts have been marked as muted.