Replace incorrect use of fmt.Errorf#3883
Merged
gotjosh merged 1 commit intoprometheus:mainfrom Jun 20, 2024
Merged
Conversation
TheMeier
approved these changes
Jun 18, 2024
Contributor
TheMeier
left a comment
TheMeier
left a comment
There was a problem hiding this comment.
failing test is the known flaky one
This commit replaces incorrect use of fmt.Errorf with errors.New in silence.go. Signed-off-by: George Robinson <george.robinson@grafana.com>
grobinson-grafana
force-pushed
the
grobinson/replace-fmt-with-errors
branch
from
893ca72 to
1493a38
Compare
Collaborator
Author
Thanks! I force pushed to restart it 😄 |
grobinson-grafana
added a commit
to grobinson-grafana/alertmanager
that referenced
this pull request
Jun 20, 2024
TheMeier
pushed a commit
to TheMeier/alertmanager
that referenced
this pull request
Sep 29, 2024
tjhop
pushed a commit
to tjhop/alertmanager
that referenced
this pull request
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces incorrect use of
fmt.Errorfwitherrors.Newinsilence.go.