jira integration template customfields#4029
Conversation
a55ee26 to
3c16236
Compare
|
Damn, seems like I forgot that. I would recommend to extend the tests. |
40cf69c to
1864d6c
Compare
5fab22c to
a6f0147
Compare
No problem, I added a new template jira.host for the unit tests, please tell me if youre fine with this. otherwise we could use some existing template to test the customfields but I think with the new template it´s cleaner |
jkroepke
left a comment
There was a problem hiding this comment.
LGTM - but I'm not an official maintainer.
|
@simonpasquier is there any chance to get this in 0.28? |
|
I´ll fix the merge conflicts If the maintainer confirm this to be merged. |
15b7215 to
a8c416f
Compare
|
@simonpasquier |
|
could someone have a look at the unit test TestClusterVSInstance, as im not able to reproduce this failure. |
|
Closes #4110 |
|
@simonpasquier could you have a look into this PR? As we´re migration to Jira Cloud we really need to have the ability to use templated custom jira fields. |
44c3ccd to
47f254c
Compare
|
Hi any prediction on this getting merged? thanks |
|
Hey @sysadmind any chance of this getting merged? We´re running this code in a production environment without any problems. |
|
Looks like there are some Go linting issues to fix. |
9927eba to
e3f1e7d
Compare
e3f1e7d to
e073bbb
Compare
|
Moved the DeepCopyWithTemplate function to template.go and improved its unit tests. |
…fields Signed-off-by: Holger Waschke <holger.waschke@dvag.com>
87e74bb to
38ae3df
Compare
Spaceman1701
left a comment
There was a problem hiding this comment.
With the small refactor and new tests, this LGTM.
I think the behavior of DeepCopyWithTemplate is a little strange, but it's practical, so let's go for it 👍
|
Thank you guys, hope this can come in a new release soon 🤞 |
We using templates to fill the jira customfields, e.g.
This code changes templates the custom fields before creating the issue, so we can use templates for custom fields