Skip to content

Discord notifier: Add username and avatar_url#4081

Merged
gotjosh merged 4 commits intoprometheus:mainfrom
featheredtoast:discord-username-avatar
Oct 24, 2024
Merged

Discord notifier: Add username and avatar_url#4081
gotjosh merged 4 commits intoprometheus:mainfrom
featheredtoast:discord-username-avatar

Conversation

@featheredtoast
Copy link
Contributor

Allow for custom username and avatar URLs to be set in discord notifications.

Add username and avatar_url to discord configuration, default empty string.

Re-introduce the rest of what was proposed in #3821 now that #4007 is merged

Allow for custom username and avatar URLs to be set in discord notifications.

Add `username` and `avatar_url` to discord configuration, default empty string.

Re-implement prometheus#3821

Signed-off-by: Jeff Wong <awole20@gmail.com>
@featheredtoast featheredtoast force-pushed the discord-username-avatar branch from 7554c16 to 4bfbecb Compare October 23, 2024 19:34
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Copy link
Member

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I've added a test for it, tested it and fixed the documentation as these are not templetables.

image

@gotjosh gotjosh enabled auto-merge (squash) October 24, 2024 20:07
@gotjosh gotjosh merged commit 95655dc into prometheus:main Oct 24, 2024
@featheredtoast featheredtoast deleted the discord-username-avatar branch November 11, 2024 08:04
tjhop pushed a commit to tjhop/alertmanager that referenced this pull request Nov 13, 2025
* Feat(discord):

Allow for custom username and avatar URLs to be set in discord notifications.

Add `username` and `avatar_url` to discord configuration, default empty string.

Re-implement prometheus#3821

Signed-off-by: Jeff Wong <awole20@gmail.com>

* Test the new fields

Signed-off-by: gotjosh <josue.abreu@gmail.com>

* These are not templeatable strings

Signed-off-by: gotjosh <josue.abreu@gmail.com>

---------

Signed-off-by: Jeff Wong <awole20@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants