Skip to content

chore(deps): use version.ComponentUserAgent#4150

Merged
SuperQ merged 1 commit intoprometheus:mainfrom
mmorel-35:prometheus/common@v0.61.0
Jan 15, 2025
Merged

chore(deps): use version.ComponentUserAgent#4150
SuperQ merged 1 commit intoprometheus:mainfrom
mmorel-35:prometheus/common@v0.61.0

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 5, 2024

Description

It migrates from github.com/prometheus/common/sigv4 to github.com/prometheus/sigv4 and uses version.ComponentUserAgent("Alertmanager") instead of fmt.Sprintf("Alertmanager/%s", version.Version)

@mmorel-35 mmorel-35 changed the title chore(deps): bump github.com/prometheus/common from 0.60.0 to 0.61.0 and use version.PrometheusUserAgent chore(deps): bump github.com/prometheus/common from 0.60.0 to 0.61.0 and use version.ComponentUserAgent Dec 5, 2024
@mmorel-35 mmorel-35 force-pushed the prometheus/common@v0.61.0 branch from f3a9da4 to 5373fd0 Compare December 5, 2024 07:28
@mmorel-35 mmorel-35 marked this pull request as draft December 5, 2024 07:31
@mmorel-35 mmorel-35 force-pushed the prometheus/common@v0.61.0 branch 2 times, most recently from ff00100 to 193eba7 Compare December 5, 2024 21:48
@mmorel-35 mmorel-35 marked this pull request as ready for review December 5, 2024 22:26
@mmorel-35 mmorel-35 marked this pull request as draft December 6, 2024 19:50
@SuperQ
Copy link
Member

SuperQ commented Jan 15, 2025

Fixed in #4168.

@SuperQ SuperQ closed this Jan 15, 2025
@mmorel-35
Copy link
Contributor Author

@SuperQ ,
Please reopen,
The use of the new method for user agent is not covered in the referenced issue

@SuperQ SuperQ reopened this Jan 15, 2025
@SuperQ
Copy link
Member

SuperQ commented Jan 15, 2025

Sorry, I missed that part.

…0 and use `version.ComponentUserAgent`

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the prometheus/common@v0.61.0 branch from 193eba7 to 77ab544 Compare January 15, 2025 16:19
@mmorel-35 mmorel-35 marked this pull request as ready for review January 15, 2025 16:20
@mmorel-35 mmorel-35 changed the title chore(deps): bump github.com/prometheus/common from 0.60.0 to 0.61.0 and use version.ComponentUserAgent chore(deps): use version.ComponentUserAgent Jan 15, 2025
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@SuperQ SuperQ merged commit 6703b0a into prometheus:main Jan 15, 2025
11 checks passed
@mmorel-35 mmorel-35 deleted the prometheus/common@v0.61.0 branch January 15, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants