Merged
Conversation
siavashs
force-pushed
the
feat-api-metrics
branch
from
5fd15b4 to
e475c70
Compare
SuperQ
requested changes
Oct 17, 2025
siavashs
force-pushed
the
feat-api-metrics
branch
from
28f4aa3 to
f25d15c
Compare
Contributor
Author
|
CircleCI is flaky as always, i think we should drop it and just use Github actions. |
Member
|
We've been slowly migrating things to GitHub Actions. While I'm not a huge fan, it's the most supported free pipeline system right now. I have a backlog TODO to refactor the promci actions into separate repos for different steps. We started it as a monorepo, which really doesn't work for actions. |
SuperQ
reviewed
Oct 19, 2025
siavashs
force-pushed
the
feat-api-metrics
branch
2 times, most recently
from
c704b54 to
6e059ae
Compare
Contributor
Author
|
Lint issues are unrelated! |
SuperQ
approved these changes
Oct 20, 2025
Member
|
Fix for test failure: #4613 |
- measure api http request duration Signed-off-by: Siavash Safi <siavash@cloudflare.com>
siavashs
force-pushed
the
feat-api-metrics
branch
from
6e059ae to
505c556
Compare
Contributor
Author
|
thanks, rebased! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.