opsgenie : trim space for api key file#4195
Merged
gotjosh merged 3 commits intoprometheus:mainfrom Mar 6, 2025
Merged
Conversation
grobinson-grafana
approved these changes
Jan 6, 2025
Collaborator
|
LGTM. Could you please write a unit test for this too? |
zoov-xavier
force-pushed
the
opsgenie_trim_api_key_file
branch
4 times, most recently
from
143e02f to
cd1de9c
Compare
Contributor
Author
|
Hello, @grobinson-grafana thanks for the review. I added some tests. Let me know if any updates are needed. |
grobinson-grafana
approved these changes
Feb 2, 2025
zoov-xavier
force-pushed
the
opsgenie_trim_api_key_file
branch
from
cd1de9c to
59b0495
Compare
Signed-off-by: zoov-xavier <xavier.jeanneney@fifteen.eu>
zoov-xavier
force-pushed
the
opsgenie_trim_api_key_file
branch
from
59b0495 to
f621e92
Compare
Contributor
Author
|
Hello, @grobinson-grafana |
SuperQ
approved these changes
Mar 3, 2025
grobinson-grafana
requested changes
Mar 5, 2025
| notifierWithUpdate, err := New(&opsGenieConfigWithUpdate, tmpl, promslog.NewNopLogger()) | ||
|
|
||
| require.NoError(t, err) | ||
| requests, _, err := notifierWithUpdate.createRequests(ctx) |
Collaborator
There was a problem hiding this comment.
You have a lint error here, as err is not checked:
ineffectual assignment to err (ineffassign)
Signed-off-by: gotjosh <josue.abreu@gmail.com>
This was referenced Mar 7, 2025
Merged
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to trim the spaces on the API key file for Opsgenie as it is already done for most other integrations (Slack, Discord, PagerDuty, etc.)