amtool: fix panic if --verbose is in used.#4218
Merged
grobinson-grafana merged 1 commit intoprometheus:mainfrom Mar 7, 2025
Merged
amtool: fix panic if --verbose is in used.#4218grobinson-grafana merged 1 commit intoprometheus:mainfrom
grobinson-grafana merged 1 commit intoprometheus:mainfrom
Conversation
jkroepke
force-pushed
the
amtool
branch
2 times, most recently
from
a2accb0 to
b81f9dd
Compare
Collaborator
|
Thanks for creating a fix for this! I appreciate that you have taken the time to add a test here, and I love it when contributors add tests, but I think in this specific case the test is not required. I would accept a PR with just |
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
grobinson-grafana
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4216
I pattern to test a command which invokes os.exit comes from https://willsena.dev/golang-how-to-test-code-that-exits-or-crashes/