Render Jira project template when searching for existing issues#4291
Merged
gotjosh merged 2 commits intoprometheus:mainfrom Mar 6, 2025
Merged
Conversation
Signed-off-by: Walther Lee <walther.lee@reddit.com>
7cc9efa to
e6924fc
Compare
Signed-off-by: Walther Lee <walther.lee@reddit.com>
grobinson-grafana
approved these changes
Mar 5, 2025
Collaborator
There was a problem hiding this comment.
There is some weird stuff happening in the tests, but it looks like they have been copied from the existing tests. We can clean those up later.
Member
Author
There was a problem hiding this comment.
Thank you! I know what you mean: the testcase overwriting a variable used in the server handler. I copied that, but I'm working on another PR and noticed that there's another test in this file that just sets up the handler inside the testcase. I'll change it here
Collaborator
There was a problem hiding this comment.
It's fine, I would prefer if you do that in another PR actually, as I've reviewed this as is and asked for it to be merged.
Member
Author
There was a problem hiding this comment.
Alright, will do. Thanks again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4159 enabled templating for Jira config fields
projectandissue_typeby rendering the templates in the request body sent to create the issue:However, it doesn't render the value in a previous request that checks if the Jira issue already exists, throwing the error:
This change adds the same template function to render the
projectvalue in the search request as well.