inhibit: compare value of different source and target labels#4351
Open
monkz wants to merge 2 commits intoprometheus:mainfrom
Open
inhibit: compare value of different source and target labels#4351monkz wants to merge 2 commits intoprometheus:mainfrom
monkz wants to merge 2 commits intoprometheus:mainfrom
Conversation
Signed-off-by: swoga <swoga@users.noreply.github.com> Signed-off-by: MonkZ <MonkZ@users.noreply.github.com>
Signed-off-by: swoga <swoga@users.noreply.github.com>
|
What would be required to get this merged? I could make use of it in our alerting. |
Contributor
|
Hi! This is an interesting change. I can definitely see the value. It's also a pretty significant behavior change, so we'll want to make sure it's something we want to support in the long term. However, I think the implementation is going to need to change pretty significantly because of the new inhibitor implementation on Would you be interested in trying to rebase this onto the latest |
|
This is not forgotten :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds equal_pairs config option to inhibit rules, which allows to compare the value of different source and target labels.
Closes #2254
Credit @swoga #3525