feat: configurable alerts provider channel capacity#4364
Closed
siavashs wants to merge 1 commit intoprometheus:mainfrom
Closed
feat: configurable alerts provider channel capacity#4364siavashs wants to merge 1 commit intoprometheus:mainfrom
siavashs wants to merge 1 commit intoprometheus:mainfrom
Conversation
siavashs
force-pushed
the
feat-alert-channel-buffer-length-config
branch
2 times, most recently
from
ced40e2 to
75bd989
Compare
Collaborator
|
Discussed here. I'm not against making this configurable, but I'm concerned that we don't understand enough about how and why this channel is becoming full and blocking. I've asked if we can get some profiles to better understand this. |
siavashs
force-pushed
the
feat-alert-channel-buffer-length-config
branch
from
75bd989 to
5ae79c8
Compare
siavashs
changed the title
siavashs
force-pushed
the
feat-alert-channel-buffer-length-config
branch
2 times, most recently
from
548a3b5 to
6814d4f
Compare
This change makes the alerts memory provider channel capacity configurable. The previously hard-coded value of 200 is used as default. Bumping this value should result in better performance and less timeouts during sudden alert spikes, specially if the pipeline speed is affected by slow receivers. The following new metrics are added with a `subscriber` label: - alertmanager_alerts_provider_channel_capacity - alertmanager_alerts_provider_channel_length Signed-off-by: Siavash Safi <siavash@cloudflare.com>
siavashs
force-pushed
the
feat-alert-channel-buffer-length-config
branch
from
6814d4f to
57827d8
Compare
Contributor
Author
|
Closing this, see the comment is linked issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the alerts memory provider channel capacity configurable.
The previously hard-coded value of 200 is used as default.
Bumping this value should result in better performance and less timeouts during sudden alert spikes, specially if the pipeline speed is affected by slow receivers.
The following new metrics are added with a
subscriberlabel: