Add new Jira search endpoint with new api_type option and auto detect#4542
Add new Jira search endpoint with new api_type option and auto detect#4542sysadmind merged 5 commits intoprometheus:mainfrom
Conversation
|
@jkroepke thanks so much for the review, I will work on your recommendations later today or tomorrow |
|
Consider to add the default value to alertmanager/config/notifiers.go Line 198 in d563660 Consider to add a validation for the values here alertmanager/config/notifiers.go Line 920 in d563660 similar to here: alertmanager/config/notifiers.go Lines 833 to 837 in d563660 |
52c097b to
67a0d97
Compare
chrko
left a comment
There was a problem hiding this comment.
The requested/recommended DefaultConfig part is missing (#4542 (comment))
Consider to add the default value to
alertmanager/config/notifiers.go
Line 198 in d563660
b6b05d3 to
b12c67e
Compare
|
@jkroepke, @chrko i added the things discussed here. is someone aware why the tests are failing? i found this in the logs |
|
Hey @sysadmind could you do a second look?
|
Signed-off-by: christianjedro <cj@cloudeteer.de>
Signed-off-by: christianjedro <cj@cloudeteer.de>
…and remove test + implementation for empty string Signed-off-by: christianjedro <cj@cloudeteer.de>
b12c67e to
64ddf67
Compare
64ddf67 to
1f6f3f2
Compare
Signed-off-by: christianjedro <cj@cloudeteer.de>
it worked now.. |
sysadmind
left a comment
There was a problem hiding this comment.
The tests are flaky with circleci. You can just run them again. I have a PR open to add the mail tests back to github actions so that we can fully move.
…#4542) * Add new Jira search endpoint with new api_type option and auto detect Signed-off-by: christianjedro <cj@cloudeteer.de> * adding recommendations, update doku, add comments Signed-off-by: christianjedro <cj@cloudeteer.de> * remove global api type (recommended by @jkroepke), add default value and remove test + implementation for empty string Signed-off-by: christianjedro <cj@cloudeteer.de> * dco Signed-off-by: christianjedro <cj@cloudeteer.de> * add better explanation Signed-off-by: christianjedro <cj@cloudeteer.de> --------- Signed-off-by: christianjedro <cj@cloudeteer.de>
|
Hi, is there any planned date to release this feature? we would like to integrate jira with our alerting workflow but we're currently struck due to Atlassian change of API in Jira Cloud |
…prometheus#4542) * Add new Jira search endpoint with new api_type option and auto detect Signed-off-by: christianjedro <cj@cloudeteer.de> * adding recommendations, update doku, add comments Signed-off-by: christianjedro <cj@cloudeteer.de> * remove global api type (recommended by @jkroepke), add default value and remove test + implementation for empty string Signed-off-by: christianjedro <cj@cloudeteer.de> * dco Signed-off-by: christianjedro <cj@cloudeteer.de> * add better explanation Signed-off-by: christianjedro <cj@cloudeteer.de> --------- Signed-off-by: christianjedro <cj@cloudeteer.de> Signed-off-by: Holger Waschke <holger.waschke@dvag.com>
closes #4513
i followed #4513 (comment)
maybe api_type = datacenter should not override host *.atlassian.net but lets discuss
also, as in the comment, only overriding the search api version for now