fix(inhibit): fix inhibitor cache & index metrics#4637
Merged
SuperQ merged 1 commit intoprometheus:mainfrom Oct 28, 2025
Merged
fix(inhibit): fix inhibitor cache & index metrics#4637SuperQ merged 1 commit intoprometheus:mainfrom
SuperQ merged 1 commit intoprometheus:mainfrom
Conversation
Inhibitor metrics were reset to zero if an alert matched no rules. This change fixes the logic by moving measurement logic out of the matching loop. Signed-off-by: Siavash Safi <siavash@cloudflare.com>
MichaHoffmann
approved these changes
Oct 28, 2025
SuperQ
approved these changes
Oct 28, 2025
holger-waschke
pushed a commit
to holger-waschke/alertmanager
that referenced
this pull request
Nov 1, 2025
Inhibitor metrics were reset to zero if an alert matched no rules. This change fixes the logic by moving measurement logic out of the matching loop. Signed-off-by: Siavash Safi <siavash@cloudflare.com> Signed-off-by: Holger Waschke <holger.waschke@dvag.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inhibitor metrics were reset to zero if an alert matched no rules.
This change fixes the logic by moving measurement logic out of the matching loop.
Fixes metrics introduced in #4629