loadSnapshot: update matcher index properly while not holding lock#4714
Merged
SuperQ merged 1 commit intoprometheus:mainfrom Nov 12, 2025
Merged
loadSnapshot: update matcher index properly while not holding lock#4714SuperQ merged 1 commit intoprometheus:mainfrom
SuperQ merged 1 commit intoprometheus:mainfrom
Conversation
Since we're building the state separately, we will do the same with the matcher index, and then update it into the Silences with the lock held. Signed-off-by: Guido Trotter <guido@hudson-trading.com>
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
siavashs
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're building the state separately, we will do the same with the matcher index, and then update it into the Silences with the lock held.