GC: report errors, but remove erroneous silences and continue#4724
Merged
SuperQ merged 1 commit intoprometheus:mainfrom Nov 13, 2025
Merged
GC: report errors, but remove erroneous silences and continue#4724SuperQ merged 1 commit intoprometheus:mainfrom
SuperQ merged 1 commit intoprometheus:mainfrom
Conversation
Signed-off-by: Guido Trotter <guido@hudson-trading.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if errors are found GC aborts, but will keep bumping into the same errors, forever.
With this change we count the errors, but also remove the problematic entries, thus becoming able to move on with the cleanup.
This change is stacked on top of #4723