refactor: replace config.Secret with commoncfg.Secret#4898
Merged
SoloJacobs merged 1 commit intoprometheus:mainfrom Feb 8, 2026
Merged
refactor: replace config.Secret with commoncfg.Secret#4898SoloJacobs merged 1 commit intoprometheus:mainfrom
SoloJacobs merged 1 commit intoprometheus:mainfrom
Conversation
TheMeier
force-pushed
the
commoncfg_secret
branch
from
33a2afa to
8032ac6
Compare
Contributor
Author
|
Sadly there is no SecretURL type in the common/config package. Since prometheus itself doesn't need it I think it is unlikely we cam move that type there. |
TheMeier
force-pushed
the
commoncfg_secret
branch
3 times, most recently
from
eeef65c to
02449f8
Compare
ultrotter
approved these changes
Jan 22, 2026
waltherlee
approved these changes
Feb 5, 2026
Member
waltherlee
left a comment
waltherlee
left a comment
There was a problem hiding this comment.
Thanks! It looks good to me ✅
TheMeier
force-pushed
the
commoncfg_secret
branch
from
02449f8 to
2d19631
Compare
To be able to move notifier specific code out of the config and notify packages, some shared code needs to be moved to other/new packages. Since commoncfg.Secret already does what config.Secret does, this replaces all usages of config.Secret. Signed-off-by: Christoph Maser <christoph.maser+github@gmail.com>
TheMeier
force-pushed
the
commoncfg_secret
branch
from
2d19631 to
8039f08
Compare
SoloJacobs
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to move notifier specific code out of the config and notify packages,
some shared code needs to be moved to other/new packages. Since commoncfg.Secret
already does what config.Secret does, this replaces all usages of config.Secret.
This requires external users of the config package to change their code if they used
config.MarshalSecretValue. This exported variable was added in
#4158