config: add global mattermost_api_url and mattermost_api_url_file#4917
config: add global mattermost_api_url and mattermost_api_url_file#4917madest92 wants to merge 4 commits intoprometheus:mainfrom
Conversation
Default Mattermost receiver webhook_url/webhook_url_file from global settings Signed-off-by: Kliachin Aleksei <madest92@gmail.com>
55bfcc5 to
6b0006e
Compare
|
Since #4812 was merged could you please try to follow it's pattern where possible? |
I've reviewed the changes. This doesn't apply to mattermost_api_url/mattermost_api_url_file. Conflict fixed. |
|
@TheMeier Now you need to write like this: Instead of What do you think about this? I can submit changes as part of this merge request, or create a new one once the current one is accepted. |
|
I personally think this should be two separate changes. Adding something is a completly different beast than breaking changes. |
|
Okay, then I'm waiting for the current changes to be accepted. |
|
@TheMeier hi Do you have any comments on Mr? |
Signed-off-by: Kliachin Aleksei <madest92@gmail.com>
|
@TheMeier hi. Who can give a second approval and merge the changes? |
|
I think this is now resolved via #4998 |
|
Hi @madest92, I just realized that you had opened a PR for the same feature before mine was merged. I'm sorry I didn't check for similar open PRs beforehand, I should have looked more carefully before submitting mine. Thank you for your work on this, and apologies again for the overlap. |
Default Mattermost receiver webhook_url/webhook_url_file from global settings