Fixing broken Yaml+ duplicate heading mentioned in Issue#4982#4983
Fixing broken Yaml+ duplicate heading mentioned in Issue#4982#4983kakabisht wants to merge 6 commits intoprometheus:mainfrom
Conversation
|
|
||
| ### `<email_config>` | ||
|
|
||
| ```yaml |
There was a problem hiding this comment.
IMHO this is ok here. This is how it looks currently:
This is how it looks with your change:
| nav_icon: network | ||
| --- | ||
|
|
||
| # High Availability |
There was a problem hiding this comment.
This also seems correct to me as this is the main headline. I also see to fail where it appears twice as claimed in #4982
|
Hi @kakabisht , we haven't back from you here in a while. It is not really clear to me what the issue is, or how this change improves the situation. So, I will go ahead and close this. Feel free to open a new issue with a clearer description (and hopefully some screen shots). Kind regards |
|
Hello @SoloJacobs @TheMeier ,
If you feel duplicate heading is not a really big dealbreaker, then i an delete branch. |
|
The change now seems good, but wen't accept this change without you signing off on the commit: |
SoloJacobs
force-pushed
the
fix-alert-docs
branch
from
de6a9e2 to
a4bcbf0
Compare
To be able to move notifier specific code out of the config and notify packages, some shared code needs to be moved to other/new packages. Since commoncfg.Secret already does what config.Secret does, this replaces all usages of config.Secret. Signed-off-by: Christoph Maser <christoph.maser+github@gmail.com> Signed-off-by: kakabisht <kakabisht07@gmail.com>
Signed-off-by: kakabisht <kakabisht07@gmail.com>
Signed-off-by: kakabisht <kakabisht07@gmail.com>
kakabisht
force-pushed
the
fix-alert-docs
branch
from
ea1f0dc to
d96ea5c
Compare
|
Fixed here instead: #5034 |
|
Hi @SoloJacobs , |
3 participants
This PR aims to fix Issue about broken YAML + duplication heading mentioned in #4982