feat: allow Slack receiver to edit existing messages#5007
Merged
siavashs merged 18 commits intoprometheus:mainfrom Feb 24, 2026
Merged
feat: allow Slack receiver to edit existing messages#5007siavashs merged 18 commits intoprometheus:mainfrom
siavashs merged 18 commits intoprometheus:mainfrom
Conversation
added 2 commits
February 11, 2026 19:09
Signed-off-by: Alexandre Joris <chaz@chaz.pro>
Signed-off-by: Alexandre Joris <chaz@chaz.pro>
30954b4 to
bf5fe52
Compare
siavashs
reviewed
Feb 12, 2026
Contributor
siavashs
left a comment
There was a problem hiding this comment.
Thanks, this LGTM in general.
Just added few comments to potentially improve the logic and config.
added 4 commits
February 12, 2026 16:16
Signed-off-by: Alexandre Joris <chaz@chaz.pro>
Signed-off-by: Alexandre Joris <chaz@chaz.pro>
Signed-off-by: Alexandre Joris <chaz@chaz.pro>
Signed-off-by: Alexandre Joris <chaz@chaz.pro>
siavashs
reviewed
Feb 16, 2026
Contributor
siavashs
left a comment
There was a problem hiding this comment.
Thanks for addressing the previous comments, I added a few more.
Signed-off-by: Alexandre Joris <chaz@chaz.pro>
Signed-off-by: Alexandre Joris <chaz@chaz.pro>
Signed-off-by: Alexandre Joris <chaz@chaz.pro>
…o warn Signed-off-by: Alexandre Joris <chaz@chaz.pro>
Co-authored-by: Siavash Safi <git@hosted.run> Signed-off-by: Alexandre Joris <alexandre.joris@gmail.com>
Signed-off-by: Alexandre Joris <chaz@chaz.pro>
siavashs
reviewed
Feb 18, 2026
Signed-off-by: Alexandre Joris <chaz@chaz.pro>
a0b4aec to
1653d20
Compare
Contributor
Spaceman1701
left a comment
There was a problem hiding this comment.
This looks very good to me!
I don't have any problems with the implementation or logic, just a few small code-style requests.
I don't think it should be (or needs to be) included in this PR, but it might be nice for a future change to provide some way for the user's template to discover it's updating an existing message. Unfortunately I think this will be a little complicated, so we can save it for later.
Signed-off-by: Alexandre Joris <chaz@chaz.pro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR adds an
update_messageconfig to Slack notifiers, that enables AlertManager to edit previously sent notifications rather than sending new ones for alert status change. It uses the nflog Store introduced in v0.31.0 to persist Slack's message Timestamp and channel ID. If retrieved, the feature will change the API endpoint tochat.updateand the request payload to attempt to edit the message.The PR is backwards compatible and this new feature requires opt-in.
Testing
Test Config
Test script
Misc
Special thanks to @kruchkov-alexandr for preliminary PR (#4682) and @Spaceman1701 for the nflog data store implementation (#4899).