Add Matrix Notifier#600
Closed
bbigras wants to merge 1 commit intoprometheus:masterfrom
bbigras:matrix
Closed
Conversation
Contributor
Author
rrix
reviewed
Mar 4, 2017
| - name: 'matrix' | ||
| matrix_configs: | ||
| - access_token: <access_token> | ||
| room_id: !<something>:matrix.org |
There was a problem hiding this comment.
Is there a way to make this not tied to matrix.org homeserver? I would like to use this with my homeserver without having to federate a room to matrix.org
freelock
reviewed
Mar 4, 2017
| data = n.tmpl.Data(receiverName(ctx), groupLabels(ctx), as...) | ||
| tmplText = tmplText(n.tmpl, data, &err) | ||
| tmplHTML = tmplHTML(n.tmpl, data, &err) | ||
| url = fmt.Sprintf("https://matrix.org/_matrix/client/r0/rooms/%s/send/m.room.message/m%d.1?access_token=%s", n.conf.RoomID, time.Now().Unix(), n.conf.AccessToken) |
There was a problem hiding this comment.
Agree with rrix, URL of Matrix Homeserver should be configurable...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I understand Matrix correctly, when you send an HTML message, you also send a plain text version so it can be shown in notifications and maybe to clients without HTML support.
I'm wondering if you find the default HTML message too complicated for the configuration page:
A room id looks like
!AAffRRJHDD:matrix.orgso I used usedroom_id: !<something>:matrix.orgin the simple.yml but maybe there's a better way.Matrix support should allow to be able to change the server (i.e. matrix.org) but I'm thinking about doing it in the next PR.