feat(metrics): support Gauge<u32, AtomicU32> type#191
feat(metrics): support Gauge<u32, AtomicU32> type#191mxinden merged 3 commits intoprometheus:masterfrom koushiro-contrib:impl-gague-atomic-u32
Gauge<u32, AtomicU32> type#191Conversation
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
|
@mxinden PTAL |
mxinden
left a comment
There was a problem hiding this comment.
Cool. Thanks. Looks good to me.
Can you bump the crate version in the root's Cargo.toml to v0.22.2 and add a CHANGELOG.md entry? Once this pull request merged, I can then cut a new release right away.
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
|
The following test: #[test]
fn encode_gauge() {
let mut registry = Registry::default();
let gauge = Gauge::<u32, AtomicU32>::default();
registry.register("my_gauge", "My gauge", gauge);
let mut encoded = String::new();
encode(&mut encoded, ®istry).unwrap();
parse_with_python_client(encoded);
}Would fail with: Mind adding an implementation of Please also extend the Sorry for the additional work. Thank you for the help. |
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
|
Thanks for your review, I have changed encoding related stuff and added a simple test case to |
Gauge<u32, AtomicU32> type
support
Gauge<u32, AtomicU32>metric