chore(portability): Support all platforms without 64 bit atomics#203
chore(portability): Support all platforms without 64 bit atomics#203mxinden merged 2 commits intoprometheus:masterfrom
Conversation
mxinden
left a comment
There was a problem hiding this comment.
target_has_atomic is neat! Thank you @navaati. Good work.
Do you have experience cross-compiling Rust for RISC-V? If so, want to add another target to the matrix here within this pull request?
client_rust/.github/workflows/rust.yml
Lines 160 to 178 in bf196d7
|
Ah, yes. It very much depends on the support from that Github Action you use, which I’m not super familiar with. The target I actually use, I’ll put out a commit with |
Yep. Will do. Thanks. |
|
Also note, you will need to sign off your commits, see failing CI step. |
346744b to
56e6b3c
Compare
|
Just triggered a CI run. |
Thanks. And it fails, as I feared the target needs the rust-std component and it’s nightly only… But you have powerpc and wasm32 which are 32-bit platforms, so it should be ok. Should I just drop that CI commit and we go as is ? |
Notably, RISC-V 32 for ESP32-C3 chips. Signed-off-by: Léo Gillot-Lamure <leo.gillot@navaati.net>
56e6b3c to
4129bb0
Compare
|
I’ve done that. Let’s merge as-is if you’re good with it ! |
Signed-off-by: Max Inden <mail@max-inden.de>
Notably, RISC-V 32 for ESP32-C3 chips. Fixes #201. Closes #202.