fix(derive-encode): Cumulative fixes#267
Open
ADD-SP wants to merge 3 commits intoprometheus:masterfrom
Open
Conversation
…EncodeLabelSet` Signed-off-by: ADD-SP <add_sp@outlook.com>
073ec36 to
2eb2dce
Compare
EncodeLabelSetSigned-off-by: ADD-SP <add_sp@outlook.com>
bbf4202 to
a63cc15
Compare
Signed-off-by: ADD-SP <add_sp@outlook.com>
a63cc15 to
9f5b1fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Better to
rebase and mergeto keep the history.EncodeLabelSet.Better to
rebase and mergeto keep the historyKeep struct generic parameters (#268)
Currently, the derive macro
EncodeLabelSetdoesn't keep the generics in theimplblock.Actually, all generics of
LabelSetwill be propagated to the structFamily,which makes concurrency programming much harder.
However, it is also usual to use non-shared
Familystruct in applications,introducing lifetime on
LabelSeteliminates extra memory copies,which could improve the performance.
To be honest, this might not shows significant improvement, so I considered it as a fix instead of perf, but this gives the freedom of utilizing lifetime to the end developer.
Emit better compilation error message (#269)
Issues
closes #268, closes #269