feat(encoding): encode usize and isize#282
Open
jalil-salame wants to merge 1 commit intoprometheus:masterfrom
Open
feat(encoding): encode usize and isize#282jalil-salame wants to merge 1 commit intoprometheus:masterfrom
jalil-salame wants to merge 1 commit intoprometheus:masterfrom
Conversation
Implement `EncodeGaugeValue` for `usize` and `isize`, and `EncodeCounterValue` for `usize`. This is very straight forward and the argument is the same as the one for `EncodeGaugeValue for u64`; if you don't do this the user code will get littered with `as i64`/`as u64`. Since these conversions are infallible for `32-bit` platforms, and have the same issues as the current `u64` impl for `64-bit` platforms, I don't think there is any problem with adding them. Signed-off-by: Jalil David Salamé Messina <jalil.salame@gmail.com>
jalil-salame
force-pushed
the
add-usize-isize-encode-impls
branch
from
cdd1bd2 to
ca8decb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
EncodeGaugeValueforusizeandisizeandEncodeCounterValueforusize. This is very straight forward and the argument is the same as the one forEncodeGaugeValue for u64; if you don't do this the user code will get littered withas i64/as u64.Since these conversions are infallible for
32-bitplatforms, and have the same issues as the currentu64impl for64-bitplatforms, I don't think there is any problem with adding them.