feat: introduce test-util feature flag#283
Closed
cratelyn wants to merge 1 commit intoprometheus:masterfrom
Closed
feat: introduce test-util feature flag#283cratelyn wants to merge 1 commit intoprometheus:masterfrom
test-util feature flag#283cratelyn wants to merge 1 commit intoprometheus:masterfrom
Conversation
for background, see discussion in prometheus#242: > > Would you be amenable to feature-gating these public helpers behind > > a `test-util` feature? This is a pretty common approach we've seen > > in other crates. > > That sounds reasonable to me. Contribution welcome. Thanks. Please > point out very prominently that we might break any of those APIs in > a patch release. \- <prometheus#242 (comment)> this commit introduces a `test-util` feature flag. this feature flag will function as a gate for additional interfaces, such as accessors to read the value of a histogram, that facilitate integration tests inspecting metrics. comments note that any forthcoming interfaces included by this feature are not subject to stability guarantees. Signed-off-by: katelyn martin <git@katelyn.world>
This was referenced Sep 2, 2025
Contributor
Author
|
👋 hello, is this still a welcome change? |
mxinden
reviewed
Oct 10, 2025
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
This looks good to me. Mind including a minimal example, e.g. for Histogram in this pull request already?
I want each pull request to leave main in a releasable state. An empty test-util feature isn't quite that.
Contributor
Author
ok. because we squash merge in this repository, some people might prefer these as separate commits. i've addressed review comments above, and pulled these changed in #242. i am going to close this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for background, see discussion in #242:
- #242 (comment)
this commit introduces a
test-utilfeature flag.this feature flag will function as a gate for additional interfaces, such as accessors to read the value of a histogram, that facilitate integration tests inspecting metrics.
comments note that any forthcoming interfaces included by this feature are not subject to stability guarantees.