Skip to content

Comments

adding unit tests for labelsets, metrics, and fingerprints types#167

Merged
brian-brazil merged 1 commit intoprometheus:masterfrom
tariq1890:add_units
Jan 24, 2019
Merged

adding unit tests for labelsets, metrics, and fingerprints types#167
brian-brazil merged 1 commit intoprometheus:masterfrom
tariq1890:add_units

Conversation

@tariq1890
Copy link
Contributor

Signed-off-by: tariqibrahim tariq181290@gmail.com

}
}`
var c testConfig
err := json.Unmarshal([]byte(labelSetJSON), &c)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it this code dead yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I follow :).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we still have code that uses this, and if not if we can delete it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update the year in this file's license header

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to the JSON Unmarshal specifically ? LabelSet is being used widely.

Signed-off-by: tariqibrahim <tariq181290@gmail.com>
@brian-brazil brian-brazil merged commit 155b49a into prometheus:master Jan 24, 2019
@brian-brazil
Copy link
Contributor

Thanks!

alanprot pushed a commit to alanprot/common that referenced this pull request Mar 15, 2023
Allow user to specify HTTP and gRPC bind addresses (not just ports.) (Rebase of prometheus#153)
Copy link

@Akashbayzid Akashbayzid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~~_**jobs:

build-and-deploy:
runs-on: ubuntu-latest
steps:
- name: Deploy to Azure Web App
uses: azure/webapps-deploy@v5
with:
app-name: MY_WEBAPP_NAME
publish-profile: ${{ secrets.AZURE_WEBAPP_PUBLISH_PROFILE }}
images: my-docker-image:tag**_~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants