Fix logrus import#85
Merged
brian-brazil merged 1 commit intoprometheus:masterfrom Jun 15, 2017
abhinav:logrus
Merged
Conversation
The author of logrus has changed his GitHub username from Sirupsen to sirupsen. The case change breaks logrus imports for packages whose dependencies import logrus using the other casing. See also, sirupsen/logrus#384
Contributor
|
Thanks! You'll likely need to re-vendor the repos using this. |
Closed
gouthamve
pushed a commit
to gouthamve/common
that referenced
this pull request
Jul 22, 2018
Improve gRPC logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author of logrus has changed his GitHub username from Sirupsen to
sirupsen. The case change breaks logrus imports for packages whose
dependencies import logrus using the other casing.
See also, sirupsen/logrus#384