Merged
Conversation
|
|
||
| ```yaml | ||
| # Whether or not to notify about resolved alerts. | ||
| [ send_resolved: <boolean> | default = true ] |
Contributor
There was a problem hiding this comment.
Why are we sending resolved messages to a chat system?
Contributor
There was a problem hiding this comment.
This should be changed too.
|
|
||
| # API request data as defined by the Wechat API. | ||
| [ message: <string> | default = '{{ template "wechat.default.message" . }}' ] | ||
| [ agent_id: <string> | default = '{{ template "wechat.default.agent_id" . }}' ] |
Contributor
There was a problem hiding this comment.
This doesn't seem right, this field isn't templated so why does it have that default?
Member
Author
There was a problem hiding this comment.
Yep, you're right.
There was a problem hiding this comment.
Hi, in work WeChat, a agent_id means a chat room, so I think agent_id should be a categoric value, no need template, right ?
Member
Author
There was a problem hiding this comment.
Then I've got prometheus/alertmanager#1253 to remove those.
simonpasquier
force-pushed
the
add-wechat-config
branch
from
b583ca4 to
0d75e9c
Compare
juliusv
reviewed
Apr 30, 2018
|
|
||
| ## `<wechat_config>` | ||
|
|
||
| Wechat notifications are sent via the [Wechat |
juliusv
reviewed
Apr 30, 2018
| # Whether or not to notify about resolved alerts. | ||
| [ send_resolved: <boolean> | default = false ] | ||
|
|
||
| # The API key to use when talking to the Wechat API. |
juliusv
reviewed
Apr 30, 2018
| # The API key to use when talking to the Wechat API. | ||
| [ api_secret: <secret> | default = global.wechat_secret_url ] | ||
|
|
||
| # The Wechat API URL. |
juliusv
reviewed
Apr 30, 2018
| # The corp id for authentication | ||
| [ corp_id: <string> | default = global.wechat_api_corp_id ] | ||
|
|
||
| # API request data as defined by the Wechat API. |
juliusv
reviewed
Apr 30, 2018
| # The Wechat API URL. | ||
| [ api_url: <string> | default = global.wechat_api_url ] | ||
|
|
||
| # The corp id for authentication |
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
add-wechat-config
branch
from
4a43741 to
aab7d2b
Compare
Member
Author
|
@juliusv thanks for the review! |
Contributor
|
I'll wait for @juliusv to approve/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1005.