Only display landing page on /#261
Merged
SuperQ merged 1 commit intoprometheus:masterfrom Oct 29, 2024
Merged
Conversation
SuperQ
requested changes
Oct 29, 2024
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Thanks! I just noticed this when I was working on prometheus/graphite_exporter#278.
Minor simplification using the existing net/http function.
Signed-off-by: Toon Schoenmakers <toon.schoenmakers@scaling.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would fix #241 we ran into this issue when some of our automated tests fully believed that node exporter was leaking a linux home directory as it was returning HTTP 200 on requests like .bash_history