Feature request: node_uname_info on *BSD

[sachaz]

Related to #1221 the node_uname_info is not enabled on *BSD

[SuperQ]

We should be able to do this on *BSD with the uname(2) syscall.

[sachaz]

is https://golang.org/pkg/runtime/#GOOS is not more reliable ?

[matthiasr]

Is it guaranteed to be the same thing? The metric name pronises information about uname, not the Go runtime. We already fetch information from the kernel directly on BSD since that is the preferred way there.

…

On Sat, Jan 5, 2019, 20:56 sachaz ***@***.***> wrote: is https://golang.org/pkg/runtime/#GOOS is not more reliable ? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1222 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAICBhdhdcTBnZLZpQzAfxQMTbj3Xi-wks5vAQNcgaJpZM4ZuMIP> .

[sachaz]

thanks for considering this request, uname is usefull on all platforms !

[sachaz]

up !

[discordianfish]

@sachaz This is accepted, now we need somebody to add support for that. PRs are welcome :)

[philipgough]

This seems to have been added for FreeBSD already. Is it reasonable to add this for Darwin? If yes I can take that.

[SuperQ]

@philipgough Go for it, PR would be welcome.

[philipgough]

@SuperQ great -will take a stab at it. What needs to be done to close this issue if FreeBSD is covered? I guess adding and testing on both openbsd and netbsd

Might as well do both.