Ethtool collector: panic: "node_ethtool_Queue[0] AllocFails" is not a valid metric name #2083
Description
Host operating system: output of uname -a
Linux tux 5.10.51 #1 SMP Thu Jul 15 22:19:10 CEST 2021 x86_64 Intel(R) Core(TM) i5-2400S CPU @ 2.50GHz GenuineIntel GNU/Linux
node_exporter version: output of node_exporter --version
node_exporter, version 1.2.0 (branch: non-git, revision: b597c12)
build user: portage@localhost
build date: 20210716-16:36:09
go version: go1.16.6
platform: linux/amd64
node_exporter command line flags
--collector.ethtool
Are you running node_exporter in Docker?
No
What did you do that produced an error?
I was excited to try the new ethtool collector in 1.2 and enabled it.
What did you expect to see?
ethtool metrics
What did you see instead?
panic: "node_ethtool_Queue[0] AllocFails" is not a valid metric name
goroutine 96 [running]:
github.com/prometheus/client_golang/prometheus.MustNewConstMetric(...)
/tmp/portage/app-metrics/node_exporter-1.2.0/homedir/go/pkg/mod/github.com/prometheus/client_golang@v1.11.0/prometheus/value.go:107
github.com/prometheus/node_exporter/collector.(*ethtoolCollector).Update(0xc00026ca40, 0xc000284060, 0x10df580, 0x0)
/tmp/portage/app-metrics/node_exporter-1.2.0/work/node_exporter-1.2.0/collector/ethtool_linux.go:186 +0x1266
github.com/prometheus/node_exporter/collector.execute(0xc0f535, 0x7, 0xcf1e20, 0xc00026ca40, 0xc000284060, 0xcf19a0, 0xc00023c640)
/tmp/portage/app-metrics/node_exporter-1.2.0/work/node_exporter-1.2.0/collector/collector.go:161 +0x84
github.com/prometheus/node_exporter/collector.NodeCollector.Collect.func1(0xc000284060, 0xc0003361b0, 0xcf19a0, 0xc00023c640, 0xc0003975e0, 0xc0f535, 0x7, 0xcf1e20, 0xc00026ca40)
/tmp/portage/app-metrics/node_exporter-1.2.0/work/node_exporter-1.2.0/collector/collector.go:152 +0x71
created by github.com/prometheus/node_exporter/collector.NodeCollector.Collect
/tmp/portage/app-metrics/node_exporter-1.2.0/work/node_exporter-1.2.0/collector/collector.go:151 +0x13c
ethtool -S eth0 says:
NIC statistics:
InPackets: 1525155
InUCast: 1423648
InMCast: 20857
InBCast: 80650
InErrors: 0
OutPackets: 1615342
OutUCast: 1610383
OutMCast: 10
OutBCast: 4949
InUCastOctets: 4609239418
OutUCastOctets: 9663166233
InMCastOctets: 5196003
OutMCastOctets: 908
InBCastOctets: 5169872
OutBCastOctets: 316736
InOctets: 4619605293
OutOctets: 9663483877
InPacketsDma: 1465120
OutPacketsDma: 1615342
InOctetsDma: 4606058808
OutOctetsDma: 9656856053
InDroppedDma: 0
Queue[0] InPackets: 432377
Queue[0] InJumboPackets: 753636
Queue[0] InLroPackets: 0
Queue[0] InErrors: 0
Queue[0] AllocFails: 0
Queue[0] SkbAllocFails: 0
Queue[0] Polls: 615012
Queue[0] OutPackets: 23072
Queue[0] Restarts: 0
Queue[1] InPackets: 433936
Queue[1] InJumboPackets: 976600
Queue[1] InLroPackets: 0
Queue[1] InErrors: 0
Queue[1] AllocFails: 0
Queue[1] SkbAllocFails: 0
Queue[1] Polls: 990271
Queue[1] OutPackets: 353545
Queue[1] Restarts: 0
Queue[2] InPackets: 92279
Queue[2] InJumboPackets: 234171
Queue[2] InLroPackets: 0
Queue[2] InErrors: 1
Queue[2] AllocFails: 0
Queue[2] SkbAllocFails: 0
Queue[2] Polls: 310637
Queue[2] OutPackets: 172772
Queue[2] Restarts: 0
Queue[3] InPackets: 506515
Queue[3] InJumboPackets: 12372
Queue[3] InLroPackets: 0
Queue[3] InErrors: 9
Queue[3] AllocFails: 0
Queue[3] SkbAllocFails: 0
Queue[3] Polls: 712999
Queue[3] OutPackets: 206824
Queue[3] Restarts: 0
I suspect this collector was not tested with a Multi-Queue NIC.