Make FS space alerts thresholds configurable#1624
Merged
SuperQ merged 2 commits intoprometheus:masterfrom Mar 2, 2020
skyscrapers:master
Merged
Make FS space alerts thresholds configurable#1624SuperQ merged 2 commits intoprometheus:masterfrom skyscrapers:master
SuperQ merged 2 commits intoprometheus:masterfrom
skyscrapers:master
Conversation
This makes it possible to tweak the thresholds for the NodeFilesystemSpaceFillingUp alerts. Which might be necessary in systems like Kubernetes, where the image garbage collector runs at 85%, so it's not a problem that the disk reaches that usage %. Signed-off-by: iuri aranda <iuri@skyscrapers.eu>
beorn7
reviewed
Feb 27, 2020
Member
beorn7
left a comment
beorn7
left a comment
There was a problem hiding this comment.
I guess this makes sense.
@SuperQ @discordianfish WDYT?
Signed-off-by: iuri aranda <iuri@skyscrapers.eu>
beorn7
approved these changes
Mar 2, 2020
Member
beorn7
left a comment
beorn7
left a comment
There was a problem hiding this comment.
Approving, but we should let @SuperQ and/or @discordianfish double-check.
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Make FS space alerts thresholds configurable (#1) This makes it possible to tweak the thresholds for the NodeFilesystemSpaceFillingUp alerts. Which might be necessary in systems like Kubernetes, where the image garbage collector runs at 85%, so it's not a problem that the disk reaches that usage %. Signed-off-by: iuri aranda <iuri@skyscrapers.eu>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Make FS space alerts thresholds configurable (#1) This makes it possible to tweak the thresholds for the NodeFilesystemSpaceFillingUp alerts. Which might be necessary in systems like Kubernetes, where the image garbage collector runs at 85%, so it's not a problem that the disk reaches that usage %. Signed-off-by: iuri aranda <iuri@skyscrapers.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to tweak the thresholds for the NodeFilesystemSpaceFillingUp alerts. Which might be necessary in systems like Kubernetes, where the image garbage collector runs at 85%, so it's not a problem that the disk reaches that usage %.
For context, this came from this issue in the
kube-prometheusproject: prometheus-operator/kube-prometheus#294cc @SuperQ @discordianfish
Signed-off-by: iuri aranda iuri@skyscrapers.eu