fix (mdstat): resync=DELAYED if md arrays in checking and allocated on same physiclal units.#170
Closed
afefelov wants to merge 3 commits intoprometheus:masterfrom
Closed
fix (mdstat): resync=DELAYED if md arrays in checking and allocated on same physiclal units.#170afefelov wants to merge 3 commits intoprometheus:masterfrom
afefelov wants to merge 3 commits intoprometheus:masterfrom
Conversation
Contributor
|
Can you update e2e-output.txt please so that the end-to-end test passes? |
collector/fixtures/proc/mdstat
Outdated
Contributor
There was a problem hiding this comment.
I think your editor may have changed the fixture here, could you double-check whether these tabs are there in reality and if so, revert those changes?
Contributor
Author
|
@brian-brazil @matthiasr : fixed |
Contributor
|
I'm still seeing spaces being removed from the fixture, on my system there's 6 spaces in |
Contributor
Author
|
@brian-brazil @matthiasr : fixed removed spaces, sorry for delay |
Contributor
|
Can you squash your commits? |
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Enabled by default collectors are chosen for Linux, which supports all of the implemented collectors. But for other OSes (OS X, for example) this list is not suitable, because they lack most of those collectors. Because of that, it is not possible to run node_exporter with default options on such OSes. Fix this by filtering list of enabled by default collectors based on their availability for current platform. Closes prometheus#149 Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
…n same physiclal units
Contributor
Author
|
Rebased, thanks for help |
Contributor
|
I think you also need to do a rebase against master. |
Contributor
Author
|
Sorry, it is not rebased against master now? |
Contributor
|
No, there's two other commits showing up in this PR. |
simonpasquier
pushed a commit
to simonpasquier/node_exporter
that referenced
this pull request
Oct 28, 2025
…openshift-4.21-golang-github-prometheus-node_exporter NO-ISSUE: Updating golang-github-prometheus-node_exporter-container image to be consistent with ART for 4.21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mdstat collector fails on my RAID6 array I have few md arrays in checking state sitting on same physical units.