Skip to content

Comments

Add runit exporter#2

Merged
discordianfish merged 2 commits intomasterfrom
feature/runit-exporter
Jul 29, 2013
Merged

Add runit exporter#2
discordianfish merged 2 commits intomasterfrom
feature/runit-exporter

Conversation

@discordianfish
Copy link
Member

It exports one metric with a label for the service name and labels for the services status:

  {
     "metric" : {
        "value" : [
           {
              "value" : 1091,
              "labels" : {
                 "want" : "down",
                 "name" : "test",
                 "normally_up" : "yes",
                 "state" : "down"
              }
           },
           {
              "value" : 8,
              "labels" : {
                 "want" : "up",
                 "name" : "test",
                 "normally_up" : "yes",
                 "state" : "up"
              }
           }
        ],
        "type" : "gauge"
     },
     "docstring" : "node_exporter: status of runit service.",
     "baseLabels" : {
        "name" : "node_service_status"
     }
  }

But maybe we should have one metric per service? Not sure about that.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cruft.

discordianfish added a commit that referenced this pull request Jul 29, 2013
@discordianfish discordianfish merged commit 4c2a270 into master Jul 29, 2013
@discordianfish discordianfish deleted the feature/runit-exporter branch July 29, 2013 07:57
botranvan referenced this pull request in bizflycloud/node_exporter Jan 27, 2021
bdrung added a commit to bdrung/node_exporter that referenced this pull request Oct 29, 2021
Sanitizing the metric names can lead to duplicate metric names:

```
caller=level.go:63 level=error caller="error gathering metrics: [from Gatherer prometheus#2] collected metric \"node_ethtool_giant_hdr\" { label:<name:\"device\" value:\"ens192\" > untyped:<value:0" msg=" > } was collected before with the same name and label values"
```

Generate a map from the sanitized metric names to the metric names from
ethtool. In case of duplicate sanitized metric names drop both metrics,
because it is unknown which one to take.

Fixes: prometheus#2185
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
SuperQ pushed a commit that referenced this pull request Nov 15, 2021
Sanitizing the metric names can lead to duplicate metric names:

```
caller=level.go:63 level=error caller="error gathering metrics: [from Gatherer #2] collected metric \"node_ethtool_giant_hdr\" { label:<name:\"device\" value:\"ens192\" > untyped:<value:0" msg=" > } was collected before with the same name and label values"
```

Generate a map from the sanitized metric names to the metric names from
ethtool. In case of duplicate sanitized metric names drop both metrics,
because it is unknown which one to take.

Fixes: #2185
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
mmolisch added a commit to mmolisch/node_exporter that referenced this pull request Apr 29, 2025
mmolisch added a commit to mmolisch/node_exporter that referenced this pull request Apr 29, 2025
Signed-off-by: Marek Molisch <marek.molisch@innovatrics.com>
mmolisch added a commit to mmolisch/node_exporter that referenced this pull request Apr 29, 2025
Signed-off-by: Marek Molisch <marek.molisch@innovatrics.com>
mmolisch added a commit to mmolisch/node_exporter that referenced this pull request Apr 29, 2025
Signed-off-by: Marek Molisch <marek.molisch@innovatrics.com>
SuperQ pushed a commit that referenced this pull request Oct 22, 2025
* * Rebase from upstream

* add sriov, power info support and pci id name resolution

Signed-off-by: Jain Johny <jj@asama.ai>

* fix/remove debug lines

Signed-off-by: Jain Johny <jj@asama.ai>

---------

Signed-off-by: Jain Johny <jj@asama.ai>

* add numa_node and missing test output file (#2)

* add numa_node and missing test output file

Signed-off-by: Jain Johny <jj@asama.ai>

* use c.logger for debug line

Signed-off-by: Jain Johny <jj@asama.ai>

* point to procfs master

Signed-off-by: Jain Johny <jj@asama.ai>

* include device_id in e2e-output pecidevice output

Signed-off-by: Jain Johny <jj@asama.ai>

* fix typo in e2e-output.txt

Signed-off-by: Jain Johny <jj@asama.ai>

* update test cases in e2e-64k-page-output.txt

Signed-off-by: Jain Johny <jj@asama.ai>

* fixing the rebase

Signed-off-by: Jain Johny <jj@asama.ai>

* move power_state to enum metric type, dont emit unavailable metrics

Signed-off-by: Jain Johny <jj@asama.ai>

* change test fixtures for power state change

Signed-off-by: Jain Johny <jj@asama.ai>

* change test fixtures for numa_node change

Signed-off-by: Jain Johny <jj@asama.ai>

---------

Signed-off-by: Jain Johny <jj@asama.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants