Conversation
exporter/runit_collector.go
Outdated
This was referenced Sep 2, 2019
bdrung
added a commit
to bdrung/node_exporter
that referenced
this pull request
Oct 29, 2021
Sanitizing the metric names can lead to duplicate metric names: ``` caller=level.go:63 level=error caller="error gathering metrics: [from Gatherer prometheus#2] collected metric \"node_ethtool_giant_hdr\" { label:<name:\"device\" value:\"ens192\" > untyped:<value:0" msg=" > } was collected before with the same name and label values" ``` Generate a map from the sanitized metric names to the metric names from ethtool. In case of duplicate sanitized metric names drop both metrics, because it is unknown which one to take. Fixes: prometheus#2185 Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
SuperQ
pushed a commit
that referenced
this pull request
Nov 15, 2021
Sanitizing the metric names can lead to duplicate metric names: ``` caller=level.go:63 level=error caller="error gathering metrics: [from Gatherer #2] collected metric \"node_ethtool_giant_hdr\" { label:<name:\"device\" value:\"ens192\" > untyped:<value:0" msg=" > } was collected before with the same name and label values" ``` Generate a map from the sanitized metric names to the metric names from ethtool. In case of duplicate sanitized metric names drop both metrics, because it is unknown which one to take. Fixes: #2185 Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
mmolisch
added a commit
to mmolisch/node_exporter
that referenced
this pull request
Apr 29, 2025
mmolisch
added a commit
to mmolisch/node_exporter
that referenced
this pull request
Apr 29, 2025
Signed-off-by: Marek Molisch <marek.molisch@innovatrics.com>
mmolisch
added a commit
to mmolisch/node_exporter
that referenced
this pull request
Apr 29, 2025
Signed-off-by: Marek Molisch <marek.molisch@innovatrics.com>
mmolisch
added a commit
to mmolisch/node_exporter
that referenced
this pull request
Apr 29, 2025
Signed-off-by: Marek Molisch <marek.molisch@innovatrics.com>
SuperQ
pushed a commit
that referenced
this pull request
Oct 22, 2025
* * Rebase from upstream * add sriov, power info support and pci id name resolution Signed-off-by: Jain Johny <jj@asama.ai> * fix/remove debug lines Signed-off-by: Jain Johny <jj@asama.ai> --------- Signed-off-by: Jain Johny <jj@asama.ai> * add numa_node and missing test output file (#2) * add numa_node and missing test output file Signed-off-by: Jain Johny <jj@asama.ai> * use c.logger for debug line Signed-off-by: Jain Johny <jj@asama.ai> * point to procfs master Signed-off-by: Jain Johny <jj@asama.ai> * include device_id in e2e-output pecidevice output Signed-off-by: Jain Johny <jj@asama.ai> * fix typo in e2e-output.txt Signed-off-by: Jain Johny <jj@asama.ai> * update test cases in e2e-64k-page-output.txt Signed-off-by: Jain Johny <jj@asama.ai> * fixing the rebase Signed-off-by: Jain Johny <jj@asama.ai> * move power_state to enum metric type, dont emit unavailable metrics Signed-off-by: Jain Johny <jj@asama.ai> * change test fixtures for power state change Signed-off-by: Jain Johny <jj@asama.ai> * change test fixtures for numa_node change Signed-off-by: Jain Johny <jj@asama.ai> --------- Signed-off-by: Jain Johny <jj@asama.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It exports one metric with a label for the service name and labels for the services status:
But maybe we should have one metric per service? Not sure about that.