Skip to content

Comments

WIP: Fix build#2055

Closed
taktv6 wants to merge 10 commits intoprometheus:masterfrom
taktv6:master
Closed

WIP: Fix build#2055
taktv6 wants to merge 10 commits intoprometheus:masterfrom
taktv6:master

Conversation

@taktv6
Copy link
Contributor

@taktv6 taktv6 commented Jun 16, 2021

No description provided.

@SuperQ
Copy link
Member

SuperQ commented Jun 16, 2021

In order to switch libraries, you need to update all use.

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to update collector/ethtool_linux_test.go to remove the reference to go-kit/kit.

go.mod Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be dropped

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@SuperQ
Copy link
Member

SuperQ commented Jun 17, 2021

You might want to git rebase -i origin/master and squash your commits.

W. Andrew Denton and others added 10 commits June 17, 2021 12:26
…htool -S")

Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>

Co-authored-by: Manuel Rüger <manuel@rueg.eu>
Signed-off-by: Oliver Geiselhardt-Herms <oliver.geiselhardt-herms@sap.com>
Signed-off-by: Oliver Geiselhardt-Herms <oliver.geiselhardt-herms@sap.com>
Signed-off-by: Oliver Geiselhardt-Herms <oliver.geiselhardt-herms@sap.com>
@taktv6 taktv6 changed the title Fix build WIP: Fix build Jun 17, 2021
@taktv6 taktv6 closed this Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants