Use SysctlTimeval for boottime collector on BSD#2208
Merged
discordianfish merged 1 commit intoprometheus:masterfrom Nov 15, 2021
Merged
Use SysctlTimeval for boottime collector on BSD#2208discordianfish merged 1 commit intoprometheus:masterfrom
discordianfish merged 1 commit intoprometheus:masterfrom
Conversation
Use SysctlTimeval from the golang.org/x/sys/unix package to simplify the implementation of the boottime collector for the BSDs and allows to build it without cgo. Tested on macOS 11.6, FreeBSD 13 and OpenBSD 7. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
boottime-bsd-simplify
branch
from
556c0ab to
78b34a4
Compare
SuperQ
approved these changes
Nov 13, 2021
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Nice, looks like there are still some other CGO requirements for various BSDs, so we can't say "no CGO" yet.
But, progress.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use SysctlTimeval from the golang.org/x/sys/unix package to
simplify the implementation of the boottime collector for the BSDs and
allows to build it without cgo.
Tested on macOS 11.6, FreeBSD 13 and OpenBSD 7.