Skip to content

Comments

rapl_collector: fix issue with invalid metric name (#2299)#2372

Merged
SuperQ merged 1 commit intoprometheus:masterfrom
aneagoe:master
May 31, 2022
Merged

rapl_collector: fix issue with invalid metric name (#2299)#2372
SuperQ merged 1 commit intoprometheus:masterfrom
aneagoe:master

Conversation

@aneagoe
Copy link
Contributor

@aneagoe aneagoe commented May 9, 2022

Fixes #2299 by wrapping metric name in SanitizeMetricName() as suggested by @discordianfish

Signed-off-by: Andrei Neagoe <3854672+aneagoe@users.noreply.github.com>
@alanorth
Copy link

Tested on a bare metal AMD EPYC 7451:

# lscpu | grep Model\ name:
Model name:          AMD EPYC 7451 24-Core Processor
BIOS Model name:     AMD EPYC 7451 24-Core Processor

Works! Before this node_exporter was crashing every fifteen seconds when I scraped.

@SuperQ
Copy link
Member

SuperQ commented May 31, 2022

Thanks, I think there was another similar PR, or issue filed. There was some discussion about making this a label.

@aneagoe
Copy link
Contributor Author

aneagoe commented May 31, 2022

@SuperQ my bad, I got the timelines mixed and thought wrapping suggestion came later. I have no preference, but I wouldn't know how to make the label change myself and atm we're a bit in limbo with this (ie no one seems to be working on converting to label). It would be great to merge this and in parallel work on a more proper solution.

@SuperQ
Copy link
Member

SuperQ commented May 31, 2022

Yea, it's a breaking change as well. I have a couple ideas, I will see if I can write something up tomorrow to fix it both ways.

For now, I think this is a sane option.

@SuperQ SuperQ merged commit e22382c into prometheus:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rapl collector crash: panic: "node_rapl_package-0-die-0_joules_total" is not a valid metric name

3 participants