rapl_collector: fix issue with invalid metric name (#2299)#2372
Merged
SuperQ merged 1 commit intoprometheus:masterfrom May 31, 2022
Merged
rapl_collector: fix issue with invalid metric name (#2299)#2372SuperQ merged 1 commit intoprometheus:masterfrom
SuperQ merged 1 commit intoprometheus:masterfrom
Conversation
Signed-off-by: Andrei Neagoe <3854672+aneagoe@users.noreply.github.com>
|
Tested on a bare metal AMD EPYC 7451: # lscpu | grep Model\ name:
Model name: AMD EPYC 7451 24-Core Processor
BIOS Model name: AMD EPYC 7451 24-Core ProcessorWorks! Before this |
Member
|
Thanks, I think there was another similar PR, or issue filed. There was some discussion about making this a label. |
Contributor
Author
|
@SuperQ my bad, I got the timelines mixed and thought wrapping suggestion came later. I have no preference, but I wouldn't know how to make the label change myself and atm we're a bit in limbo with this (ie no one seems to be working on converting to label). It would be great to merge this and in parallel work on a more proper solution. |
Member
|
Yea, it's a breaking change as well. I have a couple ideas, I will see if I can write something up tomorrow to fix it both ways. For now, I think this is a sane option. |
SuperQ
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2299 by wrapping metric name in
SanitizeMetricName()as suggested by @discordianfish