Cleanup variable naming by using systemdUnit as a prefix instead of the ambiguous "unit"#2704
Closed
conallob wants to merge 0 commit intoprometheus:masterfrom
Closed
Cleanup variable naming by using systemdUnit as a prefix instead of the ambiguous "unit"#2704conallob wants to merge 0 commit intoprometheus:masterfrom
conallob wants to merge 0 commit intoprometheus:masterfrom
Conversation
Member
|
This appears to have unrelated changes in it. |
Contributor
Author
But it's a clean branch I made this morning. Unless git branched from the branch I was in when I created this branch, instead of master. Let's wrap up #2699 first, then see if this a much smaller delta |
Member
Yes, it does that. |
conallob
force-pushed
the
systemd-cleanup-var-naming
branch
from
5119b59 to
61f290b
Compare
Contributor
Author
Given how easy it makes ignoring code review in favour of running off on your own, I'm surprised it's the default behaviour. Rebased against master now. |
Member
|
Now there is only #2699 in here |
conallob
force-pushed
the
systemd-cleanup-var-naming
branch
from
61f290b to
ff7f9d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.