Add collector for Linux EDAC by SuperQ · Pull Request #324 · prometheus/node_exporter

SuperQ · 2016-10-09T10:46:29Z

Collect "Error detection and correction" metrics from memory
controllers.

Supported on Linux only.
Add basic fixtures.
Enabled by default.

brian-brazil

Shouldn't there be a change in the end-to-end output too?

brian-brazil · 2016-10-09T10:50:30Z

collector/edac_linux.go

+func NewEdacCollector() (Collector, error) {
+	return &edacCollector{
+		ceCount: prometheus.NewDesc(
+			prometheus.BuildFQName(Namespace, edacSubsystem, "ce_count"),


_count is the suffix for Summaries/Histograms. This is probably a counter, so should be _total

I was translating the names directly without thinking about it too hard.

What about correctable_errors_total, and similar for the other names.

brian-brazil · 2016-10-09T10:51:01Z

collector/edac_linux.go

+			[]string{"controller"}, nil,
+		),
+		ueCount: prometheus.NewDesc(
+			prometheus.BuildFQName(Namespace, edacSubsystem, "ue_count"),


spell out "uncorrectable"

SuperQ · 2016-10-09T10:59:55Z

Yes, it should be in the end-to-end output, not sure why.

brian-brazil · 2016-10-09T11:01:25Z

collector/edac_linux.go

+			[]string{"controller"}, nil,
+		),
+		ueNoinfoCount: prometheus.NewDesc(
+			prometheus.BuildFQName(Namespace, edacSubsystem, "no_csrow_uncorrectable_errors_total"),


Might we want to lump these into csrow_uncorrectable_errors_total with a label like "unknown"?

Hmm. That depends on how well the kernel implements this data. In theory, unknown row + the csrow numbers should be possible to aggregate. Then we only need two metrics, one for correctable and one for uncorrectable.

discordianfish · 2017-01-03T13:37:18Z

@SuperQ What is the state of this? Is it ready to get reviewed/merged?

SuperQ · 2017-01-08T12:07:18Z

@discordianfish Ok, finally fixed up the end-to-end test. This is ready to go.

discordianfish

Looks good beside the regex question. Also needs rebasing.

discordianfish · 2017-01-09T17:43:53Z

collector/edac_linux.go

Why are the regexes needed? The globbing should already limit the files to the same, no?

The regexp is used to extract the controller number from the directory name.

Ah I see, makes sense. In general I slightly prefer doing such basic parsing manually.. then again, possibly just a personal preference. So fine with me!

discordianfish

LGTM!

juliusv · 2017-01-10T09:06:23Z

collector/edac_linux.go

correctable -> uncorrectable

juliusv · 2017-01-10T09:11:08Z

collector/edac_linux.go

csrowCeCount -> csRowCECount

csrowUeCount -> csRowUECount

juliusv · 2017-01-10T09:11:18Z

👍 otherwise

Collect "Error detection and correction" metrics from memory controllers. * Supported on Linux only. * Add basic fixtures. * Enabled by default.

Signed-off-by: prombot <prometheus-team@googlegroups.com>

SuperQ changed the title ~~Add collector for Linux EDAC~~ [WIP] Add collector for Linux EDAC Oct 9, 2016

brian-brazil reviewed Oct 9, 2016

View reviewed changes

SuperQ force-pushed the superq/edac_mc branch 2 times, most recently from cc3eb99 to dd3dc45 Compare December 13, 2016 11:29

discordianfish mentioned this pull request Dec 22, 2016

Export Linux EDAC metrics #195

Closed

discordianfish added the require/feedback label Jan 3, 2017

SuperQ force-pushed the superq/edac_mc branch 2 times, most recently from 19efeed to e8b92d3 Compare January 8, 2017 11:59

SuperQ requested a review from discordianfish January 8, 2017 12:06

SuperQ changed the title ~~[WIP] Add collector for Linux EDAC~~ Add collector for Linux EDAC Jan 8, 2017

SuperQ removed the require/feedback label Jan 8, 2017

SuperQ force-pushed the superq/edac_mc branch 2 times, most recently from 2b36015 to 374e060 Compare January 8, 2017 12:32

discordianfish reviewed Jan 9, 2017

View reviewed changes

SuperQ force-pushed the superq/edac_mc branch from 374e060 to d793aed Compare January 9, 2017 17:53

discordianfish approved these changes Jan 9, 2017

View reviewed changes

SuperQ requested a review from juliusv January 10, 2017 08:52

juliusv reviewed Jan 10, 2017

View reviewed changes

collector/edac_linux.go Outdated

Copy link

Member

juliusv Jan 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctable -> uncorrectable

juliusv reviewed Jan 10, 2017

View reviewed changes

collector/edac_linux.go Outdated

Copy link

Member

juliusv Jan 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csrowCeCount -> csRowCECount

csrowUeCount -> csRowUECount

SuperQ force-pushed the superq/edac_mc branch from d793aed to 87fd930 Compare January 10, 2017 09:13

Add collector for Linux EDAC

b4fa10c

Collect "Error detection and correction" metrics from memory controllers. * Supported on Linux only. * Add basic fixtures. * Enabled by default.

SuperQ force-pushed the superq/edac_mc branch from 87fd930 to e4566d0 Compare January 10, 2017 09:14

Update end-to-end test.

38a4a36

SuperQ force-pushed the superq/edac_mc branch from e4566d0 to 38a4a36 Compare January 10, 2017 09:23

SuperQ merged commit 12f8494 into master Jan 10, 2017

SuperQ deleted the superq/edac_mc branch January 10, 2017 09:42

SuperQ mentioned this pull request Jan 15, 2017

Release v0.14.0-rc.1. #423

Merged

tamcore pushed a commit to gitgrave/node_exporter that referenced this pull request Oct 22, 2024

Update common Prometheus files (prometheus#324)

b98b0d5

Signed-off-by: prombot <prometheus-team@googlegroups.com>

Comments

Conversation

SuperQ commented Oct 9, 2016

Uh oh!

brian-brazil left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SuperQ commented Oct 9, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

discordianfish commented Jan 3, 2017

Uh oh!

SuperQ commented Jan 8, 2017

Uh oh!

discordianfish left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

discordianfish left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juliusv commented Jan 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants