Conversation
Specifically, uname syscall support on Linux is controlled by a build tag white list, and both mips64 platforms were missing from the list.
|
Hell yes to getting node_exporter for EdgeRouters, |
|
@SuperQ Thanks! I ran Shall I make this pull request include just the build tag fix 4f479e5 and sort out the promu business separately? Is there some other validation I can/should run? |
|
@sdurrheimer Any comment here? |
|
Yes, I think splitting out the uname syscall change into a separate PR would be good. I think the cgo issue is going to be solved on the promu side. |
|
We can't disable
I'm currently not so sure this is a |
649d98c to
4f479e5
Compare
|
@SuperQ Done, this PR contains only 4f479e5 now. The Circle failure looks spurious. Is that broken at master? @sdurrheimer 😊 Oops, I see there are a ton more cgo dependencies left for BSD and Solaris, sorry; I misunderstood the commit message for 2ee8470. Now that I'm nerd sniped by this, I'll play around to see if I can get linux/mips working with promu and cgo; it looks like the builder image has something bogus going on with its installed system headers for MIPS cross builds. |
|
Sorry for the delay in getting this reviewed. Let us know if you make progress on getting the cross builds working better. It'd be nice to be enable as many platforms as we can for node_exporter. |
|
Thanks for the merge, folks. I'll be in touch. 😄 |
Just a quick drive-by fix for the linux/mips64 builds so I can export metrics from my EdgeRouter 😄