Conversation
superdump
reviewed
Dec 19, 2016
README.md
Outdated
Member
Author
There was a problem hiding this comment.
Ops, thanks - fixed. Copied it without checking from the issue.
discordianfish
force-pushed
the
fish-update-docker-readme
branch
from
bf9f8fd to
8d9edf2
Compare
SuperQ
reviewed
Dec 19, 2016
README.md
Outdated
SuperQ
reviewed
Dec 19, 2016
README.md
Outdated
Member
There was a problem hiding this comment.
Maybe "designed to monitor the host system"
Member
Author
There was a problem hiding this comment.
@SuperQ I went for a more technical description. Why do you think 'designed to monitor' is better than 'requires access to'? I imaging if we use the former, people might say: "well, designed for - but I still want to run it in Docker and Prometheus peepz don't allow it"
Member
There was a problem hiding this comment.
Maybe to make it overly clear, mention both aspects. :)
Member
Author
There was a problem hiding this comment.
Makes sense. Like this?
discordianfish
force-pushed
the
fish-update-docker-readme
branch
from
8d9edf2 to
b681b93
Compare
This adds bind-mounts and ignore flags to Docker example and explains why it's best run uncontainerized.
discordianfish
force-pushed
the
fish-update-docker-readme
branch
from
b681b93 to
21173e2
Compare
Member
Author
|
@SuperQ Good to merge? |
SuperQ
approved these changes
Dec 20, 2016
Merged
tamcore
pushed a commit
to gitgrave/node_exporter
that referenced
this pull request
Oct 22, 2024
Add NetClassByIface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds bind-mounts and ignore flags to Docker example and explains
why it's best run uncontainerized.