Fixed panic when parsing /proc/stat on 2.6.32-25-pve#39
Merged
grobie merged 1 commit intoprometheus:masterfrom Feb 7, 2015
Merged
Fixed panic when parsing /proc/stat on 2.6.32-25-pve#39grobie merged 1 commit intoprometheus:masterfrom
grobie merged 1 commit intoprometheus:masterfrom
Conversation
collector/stat.go
Outdated
Member
There was a problem hiding this comment.
Variable-naming-wise, I've been trying to figure out what "ex" could mean (meaning that should probably be clarified). What's the intended meaning?
Contributor
Author
There was a problem hiding this comment.
ex is expected, I felt like expectedFieldNum would be too long.
Member
There was a problem hiding this comment.
Ahhh, ok... too many potential words starting with "ex" - this one didn't cross my mind :)
Maybe just "numFields"?
Member
There was a problem hiding this comment.
I see you changed it to "expected..." now. Fine as well!
Member
|
👍 Please squash and I'll merge. Thanks! |
Fixes issue described in prometheus#38 /proc/stat reports a blank line which needs to be ignored. Old kernels misses one CPU time field, this needs to be ignored too.
Contributor
Author
|
Done. |
Member
|
Thanks! |
grobie
added a commit
that referenced
this pull request
Feb 7, 2015
Fixed panic when parsing /proc/stat on 2.6.32-25-pve
bdrung
added a commit
to bdrung/node_exporter
that referenced
this pull request
Aug 16, 2021
Add a `node_ethtool_info` metric to all ethtool devices to expose driver information with following labels: * bus_info * driver * expansion_rom_version * firmware_version * version This metric is useful to monitor the firmware version to be up-to-date. Note: The version label might be malformed due to bug prometheus#39 in ethtool: safchain/ethtool#39 Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
discordianfish
pushed a commit
that referenced
this pull request
Aug 16, 2021
Add a `node_ethtool_info` metric to all ethtool devices to expose driver information with following labels: * bus_info * driver * expansion_rom_version * firmware_version * version This metric is useful to monitor the firmware version to be up-to-date. Note: The version label might be malformed due to bug #39 in ethtool: safchain/ethtool#39 Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
tamcore
pushed a commit
to gitgrave/node_exporter
that referenced
this pull request
Oct 22, 2024
Replace AUTHORS.md by an updated MAINTAINERS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue described in #38
/proc/stat reports a blank line which needs to be ignored.
Old kernels misses one CPU time field, this needs to be ignored too.