Skip to content

Comments

Add a textfile helper for NTPd.#458

Merged
discordianfish merged 1 commit intomasterfrom
bjk/ntpd_metrics
Feb 14, 2017
Merged

Add a textfile helper for NTPd.#458
discordianfish merged 1 commit intomasterfrom
bjk/ntpd_metrics

Conversation

@SuperQ
Copy link
Member

@SuperQ SuperQ commented Feb 10, 2017

Parse the output of ntpq -np to provide metrics from a local NTP
daemon.

Parse the output of `ntpq -np` to provide metrics from a local NTP
daemon.
Copy link
Contributor

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not a Python expert either.

@SuperQ SuperQ mentioned this pull request Feb 14, 2017
@discordianfish
Copy link
Member

Why not use ntplib and do it python native? But this LGTM as well.

@SuperQ
Copy link
Member Author

SuperQ commented Feb 14, 2017

ntplib implements the NTP protocol, not the ntpd command and control protocol. I haven't been able to find a native library for that.

@discordianfish discordianfish merged commit d354971 into master Feb 14, 2017
@discordianfish
Copy link
Member

Well then :)

@mdlayher mdlayher deleted the bjk/ntpd_metrics branch November 7, 2017 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants