Skip to content

Comments

sysfs: change power supply scope to string#146

Merged
discordianfish merged 1 commit intoprometheus:masterfrom
shaardie:fix_power_supply_scope
Apr 3, 2019
Merged

sysfs: change power supply scope to string#146
discordianfish merged 1 commit intoprometheus:masterfrom
shaardie:fix_power_supply_scope

Conversation

@shaardie
Copy link
Contributor

@shaardie shaardie commented Mar 22, 2019

/sys/class/power_supply/<power_supply>/scope is currently parsed as
uint64, but is is actually a string, see #145.

Signed-off-by: Sven Haardiek sven.haardiek@iotec-gmbh.de

@shaardie shaardie changed the title sysfs: change power supply scope to string (#145) sysfs: change power supply scope to string Mar 22, 2019
@SuperQ
Copy link
Member

SuperQ commented Mar 22, 2019

It looks like we need to update the build Go versions.

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I pushed #147 to fix the test issues.

@SuperQ
Copy link
Member

SuperQ commented Mar 22, 2019

Ok, #147 is merged, please rebase.

/sys/class/power_supply/<power_supply>/scope is currently parsed as
uint64, but is is actually a string.

Signed-off-by: Sven Haardiek <sven.haardiek@iotec-gmbh.de>
@shaardie shaardie force-pushed the fix_power_supply_scope branch from e25ec71 to b4c564e Compare March 25, 2019 09:36
@discordianfish discordianfish merged commit ea9eea6 into prometheus:master Apr 3, 2019
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
sysfs: change power supply scope to string
bobrik pushed a commit to bobrik/procfs that referenced this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants