Parsing Mountinfo to get information not in mountstats#173
Parsing Mountinfo to get information not in mountstats#173pgier merged 6 commits intoprometheus:masterfrom dipack95:mountinfo
Conversation
Signed-off-by: Dipack P Panjabi <dpanjabi@hudson-trading.com>
Signed-off-by: Dipack P Panjabi <dpanjabi@hudson-trading.com>
|
@pgier Can you take a look at this? |
pgier
left a comment
pgier
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I added some comments in-line.
Signed-off-by: Dipack P Panjabi <dpanjabi@hudson-trading.com>
|
@pgier Thanks for the feedback! I've modified the code to bring them in line with your suggestions. |
mountinfo.go
Outdated
| @@ -0,0 +1,171 @@ | |||
| // Copyright 2018 The Prometheus Authors | |||
There was a problem hiding this comment.
New files should get the current year. Please update this to 2019.
mountinfo.go
Outdated
| "strings" | ||
| ) | ||
|
|
||
| var validOptionalFields = map[string]bool{"shared": true, "master": true, "propagate_from": true, "unbindable": true} |
There was a problem hiding this comment.
Please break up this long line.
var (
validOptionalFields = map[string]bool{
"shared": true,
...
Signed-off-by: Dipack P Panjabi <dpanjabi@hudson-trading.com>
|
@SuperQ I've made the changes as you requested! Thanks for the feedback. |
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Please apply comment rules to all comments added by this PR.
mountinfo_test.go
Outdated
| @@ -0,0 +1,135 @@ | |||
| // Copyright 2018 The Prometheus Authors | |||
There was a problem hiding this comment.
Yup, my bad. Just fixed it.
Signed-off-by: Dipack P Panjabi <dpanjabi@hudson-trading.com>
|
@SuperQ Do you think the PR is in an acceptable state right now? |
|
@SuperQ Gentle reminder! :) |
proc.go
Outdated
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2018 The Prometheus Authors | |||
| // Copyright 2019 The Prometheus Authors | |||
There was a problem hiding this comment.
I think this copyright date should remain 2018 since the file already existed before this change.
There was a problem hiding this comment.
Okay, I'll change it now
Signed-off-by: Dipack P Panjabi <dpanjabi@hudson-trading.com>
|
@pgier I am currently using the changes in this PR in my own fork of I was hoping that could create a new release of |
|
@dipack95 I'd like to get a couple more PRs merged and then I'll tag a new release probably some time next week. |
Parsing Mountinfo to get information not in mountstats
Build with cargo update -Z minimal-versions
4 participants
As @SuperQ said here, I've added parsing for
mountinfotoprocfs, along with test cases for it.