Conversation
79f28ad to
5832b1b
Compare
pgier
left a comment
There was a problem hiding this comment.
Looks good, just a couple minor nits.
@discordianfish @mdlayher What do you think regarding the use of reflect here?
22cbd4c to
b6c426b
Compare
53daa2c to
19f28d7
Compare
bb4bbc5 to
fdc82b8
Compare
|
@pgier i changed the MR using the same pattern. I used your util ValueParser.Pint64 although I don't use pointers here, I wonder if that should be changed also. Also simply unpacking/re-packing the fixtures.ttar with the provided makefile leads to re-ordering. |
|
The fixtures file ordering should be fixed by #185 |
Read data from /proc/sys/vm entries Closes: prometheus#157 Signed-off-by: Christoph Maser <christoph.maser+github@gmail.com>
|
@pgier hm fair question the documentation at https://www.kernel.org/doc/Documentation/sysctl/vm.txt doesn't really say anything about data format. |
Actually I just realized I should have used pointers here. In case the valueparser comes back with nil the current implementation will lead to: Will open an issue and patch... |
Process: Add support for network
Read data from /proc/sys/vm entries
Closes: #157
Theres still work to be done for
lowmem_reserve_ratio, actually i don't understand the format yet fully especially when dealing with NUMA zones.